indexing (not working currently) #116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
requested changes
Feb 24, 2020
| .object_at(0) | ||
| .unwrap() | ||
| .color_attachments()[0] | ||
| // .object_at(0) |
There was a problem hiding this comment.
let's clean up all these comments
| .set_pixel_format(MTLPixelFormat::BGRA8Unorm); | ||
|
|
||
| device | ||
| .new_render_pipeline_state(&pipeline_state_descriptor) | ||
| .unwrap() | ||
| } | ||
|
|
||
| fn ppd(desc: &mut RenderPassDescriptorRef) { | ||
| // let color_attachment = &desc.color_attachments()[0]; | ||
| desc.color_attachments()[0] = desc.color_attachments()[0].to_owned(); |
There was a problem hiding this comment.
We can live with the fact this doesn't work. It doesn't have to be provided - users can still do set_object_at, right?
|
|
||
| pub fn set_object_at(&self, index: usize, buffer_desc: Option<&AttributeDescriptorRef>) { | ||
| unsafe { msg_send![self, setObject:buffer_desc atIndexedSubscript:index] } | ||
| impl std::ops::IndexMut<NSUInteger> for AttributeDescriptorArrayRef { |
There was a problem hiding this comment.
It seems to me that this isn't actually needed. Today, metal-rs doesn't enforce thread guarantees (unfortunately!) so all the methods are &self. Therefore, there isn't a case where we'd need &mut self.
In the future, it will definitely be desired to make us properly Send/Sync/Clone/&mut, but this is out of scope of this PR.
|
@adamnemecek ping. Are you interested to land this one day? |
|
I’ll revisit this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.