Skip to content
This repository has been archived by the owner on Jan 29, 2025. It is now read-only.

[wgsl-in] Fix error message for invalid texture{Load,Store}() on 2d_array #2432

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

fornwall
Copy link
Contributor

Fixes #2431.

@fornwall fornwall force-pushed the fix-texture-store-wrong-argcount branch from 51214d4 to c53d7da Compare August 11, 2023 07:32
@fornwall fornwall changed the title [wgsl-in] Fix error message for invalid textureStore() on 2d_array [wgsl-in] Fix error message for invalid texture{Load,Store}() on 2d_array Aug 11, 2023
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@teoxoy
Copy link
Member

teoxoy commented Aug 11, 2023

Could you rebase so that we get the CI fix?

@fornwall fornwall force-pushed the fix-texture-store-wrong-argcount branch from c53d7da to 98014d3 Compare August 11, 2023 14:28
@fornwall
Copy link
Contributor Author

Could you rebase so that we get the CI fix?

Done!

@teoxoy teoxoy merged commit 30afa5b into gfx-rs:master Aug 11, 2023
@fornwall fornwall deleted the fix-texture-store-wrong-argcount branch August 13, 2023 21:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wgsl-in] Broken error message for invalid textureStore() on 2d_array
2 participants