Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use argument buffers on Metal #2547

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

Use argument buffers on Metal #2547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
990f24d
Refactor: extract entry point validation to function
kanerogers Sep 15, 2023
e8f9064
Ignore VScode workspaces
kanerogers Sep 15, 2023
3491380
WIP - beginning to write argument buffer
kanerogers Sep 15, 2023
5dcf54a
Write out argument buffer struct
kanerogers Sep 15, 2023
86de7a5
Continue to implement argument buffer
kanerogers Sep 18, 2023
8d48d02
Handle binding arrays better
kanerogers Sep 18, 2023
d156789
Sort bindings by group when creating argument buffers
kanerogers Sep 18, 2023
cbd3f91
WIP - Using argument buffers inside functions
kanerogers Sep 18, 2023
3afe315
Handle usage of global variables in functions
kanerogers Sep 18, 2023
fe21864
Handle more edge cases in buffer acces
kanerogers Sep 18, 2023
091895b
Refactor write_functions
kanerogers Sep 22, 2023
dc1718c
More refactoring, fix argument buffers
kanerogers Sep 22, 2023
4e4cb3a
Revert to previous method of ID generation
kanerogers Sep 22, 2023
0285eab
Provide information about argument buffer created
kanerogers Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,4 @@ Cargo.lock
/*.wgsl
/*.hlsl
/*.txt
*.code-workspace
7 changes: 5 additions & 2 deletions src/back/msl/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ mod writer;

pub use writer::Writer;

use self::writer::EntryPointInfo;

pub type Slot = u8;
pub type InlineSamplerIndex = u8;

Expand Down Expand Up @@ -79,6 +81,7 @@ pub struct EntryPointResources {

pub type EntryPointResourceMap = std::collections::BTreeMap<String, EntryPointResources>;

#[derive(Debug, Clone)]
enum ResolvedBinding {
BuiltIn(crate::BuiltIn),
Attribute(u32),
Expand All @@ -94,7 +97,7 @@ enum ResolvedBinding {
Resource(BindTarget),
}

#[derive(Copy, Clone)]
#[derive(Debug, Copy, Clone)]
enum ResolvedInterpolation {
CenterPerspective,
CenterNoPerspective,
Expand Down Expand Up @@ -494,7 +497,7 @@ pub struct TranslationInfo {
/// corresponds to an entry point index.
///
///Note: Some entry points may fail translation because of missing bindings.
pub entry_point_names: Vec<Result<String, EntryPointError>>,
pub entry_point_info: Vec<Result<EntryPointInfo, EntryPointError>>,
}

pub fn write_string(
Expand Down
Loading