Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] make use of resolve_type wherever possible #2565

Merged
merged 1 commit into from
Oct 18, 2023
Merged

[refactor] make use of resolve_type wherever possible #2565

merged 1 commit into from
Oct 18, 2023

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Oct 18, 2023

Makes code nicer. The SPIR-V backend is missing a resolve_type fn but we can add that later.

@teoxoy teoxoy requested a review from a team as a code owner October 18, 2023 13:38
jimblandy
jimblandy approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

@jimblandy jimblandy merged commit 5b65f11 into gfx-rs:master Oct 18, 2023
5 checks passed
@teoxoy teoxoy deleted the resolve_type branch October 18, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimblandy jimblandy jimblandy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teoxoy @jimblandy