Skip to content
This repository has been archived by the owner on Jan 29, 2025. It is now read-only.

[wgsl-in] consolidate type resolution logic in a few macros #2571

Merged
merged 3 commits into from
Oct 19, 2023
Merged

[wgsl-in] consolidate type resolution logic in a few macros #2571

merged 3 commits into from
Oct 19, 2023

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Oct 19, 2023

No description provided.

@teoxoy teoxoy requested a review from a team October 19, 2023 17:10
jimblandy
jimblandy approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice cleanup.

These need documentation, both for usage and their rationale for existence.

src/front/wgsl/lower/mod.rs Outdated Show resolved Hide resolved
src/front/wgsl/lower/mod.rs Show resolved Hide resolved
@jimblandy jimblandy merged commit 19209b6 into gfx-rs:master Oct 19, 2023
@teoxoy teoxoy deleted the type-resolution-macros branch October 19, 2023 20:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jimblandy jimblandy jimblandy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teoxoy @jimblandy