New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String passed to the callback must be null terminated #451

Merged

cwfitzgerald merged 2 commits into gfx-rs:trunk from levydsa:null_string

Jan 14, 2025

Contributor

levydsa commented Jan 12, 2025

This is quite hard to spot. Stumbled upon it while trying to force wgpuInstanceRequestAdapter to return a message in the response.


          fix: string passed to the callback must be null terminated

9ef510f

cwfitzgerald approved these changes

View reviewed changes

Member

cwfitzgerald left a comment

Looks good, have a nit

src/lib.rs Outdated Show resolved Hide resolved


          refactor: use c string literal

f26e039

Co-authored-by: Connor Fitzgerald <[email protected]>

cwfitzgerald merged commit a3d1589 into gfx-rs:trunk

16 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet