Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wgpu gl support #502

Closed
wants to merge 5 commits into from
Closed

Conversation

zicklag
Copy link
Contributor

@zicklag zicklag commented Feb 25, 2020

Discussion: #450.

@zicklag zicklag requested a review from kvark February 25, 2020 02:59
@zicklag zicklag mentioned this pull request Feb 25, 2020
Copy link
Contributor

@monocodus monocodus bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is autogenerated code-style review, new suggestions: 1

@zicklag
Copy link
Contributor Author

zicklag commented Aug 30, 2020

Superceded by #907 .

@zicklag zicklag closed this Aug 30, 2020
kvark added a commit to kvark/wgpu that referenced this pull request Jun 3, 2021
502: Expose get_bind_group_layout r=grovesNL a=kvark

Returning a new object is fine for BGLs specifically and for these cases in particular because we made sure the refcount is bumped (and BGL has a special kind of refcount) in gfx-rs@f164fd1

Co-authored-by: Dzmitry Malyshau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant