Skip to content

[naga] Ensure test functions in glsl snapshots are reachable from the entry point #7672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

andyleiserson
Copy link
Contributor

For #5885, we are planning to change compaction to remove unreferenced functions.

This change ensures that test functions in GLSL snapshots are reachable from the entry point, so that when we start pruning unreachable functions, we do not lose test coverage.

This is the first of three similar changes to tests. The others are for the WGSL snapshot tests and for the non-snapshot naga tests.

Squash or Rebase? Squash

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@andyleiserson andyleiserson merged commit 2a924a3 into gfx-rs:trunk May 7, 2025
37 checks passed
@andyleiserson andyleiserson deleted the snapshot-entrypoints-glsl branch May 7, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants