-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve progress bar #10821
Merged
Merged
Improve progress bar #10821
+304
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericcurtin
force-pushed
the
progress-bar
branch
8 times, most recently
from
December 14, 2024 13:26
31b446e
to
b8956b8
Compare
ericcurtin
commented
Dec 14, 2024
ericcurtin
force-pushed
the
progress-bar
branch
17 times, most recently
from
December 15, 2024 12:07
1090741
to
23b1d44
Compare
@ggerganov @slaren this is ready for review |
ericcurtin
force-pushed
the
progress-bar
branch
2 times, most recently
from
December 16, 2024 12:19
6d8e249
to
2d05bf3
Compare
ericcurtin
force-pushed
the
progress-bar
branch
7 times, most recently
from
December 16, 2024 19:16
dd78c36
to
e55e673
Compare
It crashes when I try to run with a local file: $ git log -1
commit e55e67314c42360176643364c1277897eff96d78 (HEAD -> pr/10821)
Author: Eric Curtin <[email protected]>
Date: Fri Dec 13 22:46:13 2024 +0000
Improve progress bar
Set default width to whatever the terminal is. Also fixed a small bug around
default n_gpu_layers value.
Signed-off-by: Eric Curtin <[email protected]>
$ ./build/bin/llama-run ./models/llama-3.2-3b-instruct/ggml-model-f16.gguf
curl_easy_perform() failed: Failure when receiving data from the peer
libc++abi: terminating due to uncaught exception of type nlohmann::json_abi_v3_11_3::detail::parse_error: [json.exception.parse_error.101] parse error at line 1, column 1: attempting to parse an empty input; check that your input string or stream contains the expected JSON
Abort trap: 6 |
Looking now |
Thanks for reporting @ggerganov , fixed with:
|
ericcurtin
force-pushed
the
progress-bar
branch
from
December 17, 2024 12:13
e55e673
to
b876712
Compare
Fix pushed |
ericcurtin
force-pushed
the
progress-bar
branch
from
December 17, 2024 12:15
b876712
to
89a2e35
Compare
slaren
reviewed
Dec 17, 2024
ericcurtin
force-pushed
the
progress-bar
branch
5 times, most recently
from
December 17, 2024 16:10
3bb5568
to
7191fb0
Compare
slaren
reviewed
Dec 17, 2024
slaren
reviewed
Dec 17, 2024
Set default width to whatever the terminal is. Also fixed a small bug around default n_gpu_layers value. Signed-off-by: Eric Curtin <[email protected]>
ericcurtin
force-pushed
the
progress-bar
branch
from
December 17, 2024 19:00
7191fb0
to
bf51f65
Compare
slaren
approved these changes
Dec 19, 2024
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Dec 20, 2024
Set default width to whatever the terminal is. Also fixed a small bug around default n_gpu_layers value. Signed-off-by: Eric Curtin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set default width to whatever the terminal is. Also fixed a small bug around default n_gpu_layers value.