-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sycl-exp : unify rope neox/norm #7919
Conversation
As per: #7634 Signed-off-by: Joe Todd <[email protected]>
Rope is only supported for contiguous input data. Concat currently only supports dim=2 Signed-off-by: Joe Todd <[email protected]>
Signed-off-by: Joe Todd <[email protected]>
@ggerganov the target branch for this PR is We decided to open the branch here, rather than in a fork, so that there's more visibility on our work from other llama.cpp developers. However, I can see that this might cause some confusion relating to duplicate PRs etc. Would you prefer that we take our |
@joeatodd No problem at all - feel free to create the branches here for more visibility |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, otherwise changes seem fine
Signed-off-by: Joe Todd <[email protected]>
This PR updates the SYCL backend as per #7634. It also updates
ggml_backend_sycl_supports_op
to reflect the fact that: