ggml : fix handling of zero blocks in IQ quants #7955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ggml
mofosyne
added
the
Review Complexity : Low
CISC
reviewed
Jun 16, 2024
| @@ -13139,7 +13139,7 @@ static int iq1_find_best_neighbour(const uint16_t * restrict neighbours, const u | |||
| const float * restrict xval, const float * restrict weight, float * scale, int8_t * restrict L, int ngrid) { | |||
| int num_neighbors = neighbours[0]; | |||
| GGML_ASSERT(num_neighbors > 0); | |||
| float best_score = 0; | |||
| float best_score = -FLT_MAX; | |||
There was a problem hiding this comment.
This function isn't used any more, but why negative FLT_MAX?
There was a problem hiding this comment.
Any negative value works, but used -FLT_MAX for consistency with usage of FLT_MAX elsewhere in the source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for blocks full of 0s