Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application credential support #382

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

diedpigs
Copy link

This patch make the plugin support application credential in openstack.

Add condition at adding password to post body
Update get_body_3 to have application credential body if auth type is
 set to v3applicationcredentail
Add three variables:
 app_cred_id, app_cred_secret, and openstack_auth_type
Define validate_auth_type method
Move password, username required check into validate_auth_type method
 since application credential doesnt require username and password
Update validate_api_version method
 since application credential doesnt require other variables like:
 user_domain or project_name
app_cred_id_required and app_cred_secret_required
@coveralls
Copy link

coveralls commented Jun 18, 2019

Coverage Status

Coverage increased (+0.02%) to 87.527% when pulling 339bd1e on diedpigs:app-cred into 30964bd on ggiamarchi:master.

Add app_cred_id and app_cred_secret
Add keystone_request_body_app_cred
Add context with good application credentials
Add context with wrong application credentials
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants