Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump github.com/ggicci/owl from 0.4.0 to 0.6.0 #80

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 13, 2023

Bumps github.com/ggicci/owl from 0.4.0 to 0.6.0.

Release notes

Sourced from github.com/ggicci/owl's releases.

v0.6.0

New Features

Sort directives at tree build time and resolving/scanning runtime:

type Record struct {
	R1 string `owl:"DOTA=2;csgo=1"`
	R2 string `owl:"apple=green;pear;Grape=purple"`
}

1. When passing the option to New:

owl.New(Record{}, owl.WithDirectiveRunOrder(func(d1, d2 *owl.Directive) bool {
    return strings.ToLower(d1.Name) < strings.ToLower(d2.Name) // sort directives by name (alphabetical order)
}))

the directives will be sorted at tree build stage. I.e. The Resolver built for field Record.R2 looks like this:

Resolver(R2).Directives ==> []*Directive {
    &Directive{Name: "apple", Argv: { "green" }},
    &Directive{Name: "Grape", Argv: { "purple" }},
    &Directive{Name: "apple", Argv: {}},
}

Actually we can use the API Resolver.Iterate to achieve the same result.

2. When passing the option to Resolve or Scan:

resolver.Scan(form, owl.WithDirectiveRunOrder(func(d1, d2 *owl.Directive) bool {
    return d1.Name == "default" // makes default directive run first
}))

the original directives order won't be affected. A copy of the directives will be created an sorted.

v0.5.1

Fix the definition of nested directives.

type CreateUserRequest struct {
</tr></table> 

... (truncated)

Commits
  • 8fffb3d feat: allow sorting directives WithDirectiveRunOrder
  • 21dcd8f fix: define nested and non-nested directives
  • a1fee3a fix: can override option in Resolve/Scan, rename WithNestedDirectivesEnabled
  • db45554 fix: pass WithResolveNestedDirectives(bool) to Resolve, not New
  • 5d19961 feat: new option WithResolveNestedDirectives
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/ggicci/owl](https://github.com/ggicci/owl) from 0.4.0 to 0.6.0.
- [Release notes](https://github.com/ggicci/owl/releases)
- [Commits](ggicci/owl@v0.4.0...v0.6.0)

---
updated-dependencies:
- dependency-name: github.com/ggicci/owl
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5317ab1) 96.74% compared to head (1b235be) 96.74%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   96.74%   96.74%           
=======================================
  Files          21       21           
  Lines         707      707           
=======================================
  Hits          684      684           
  Misses         16       16           
  Partials        7        7           
Flag Coverage Δ
unittests 96.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 18, 2023

Superseded by #83.

@dependabot dependabot bot closed this Dec 18, 2023
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/ggicci/owl-0.6.0 branch December 18, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants