Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue 88, streaming #92

Merged
merged 1 commit into from
Jan 14, 2024
Merged

fix: issue 88, streaming #92

merged 1 commit into from
Jan 14, 2024

Conversation

ggicci
Copy link
Owner

@ggicci ggicci commented Jan 14, 2024

Fixes #88

Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (fbcb1f2) 90.77% compared to head (d7c8134) 90.73%.

Files Patch % Lines
core/requestbuilder.go 73.80% 9 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
- Coverage   90.77%   90.73%   -0.05%     
==========================================
  Files          33       33              
  Lines        1464     1479      +15     
==========================================
+ Hits         1329     1342      +13     
- Misses         90       93       +3     
+ Partials       45       44       -1     
Flag Coverage Δ
unittests 90.73% <74.41%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ggicci ggicci merged commit 5dca4c8 into main Jan 14, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impossible to make streaming
1 participant