Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose core.ErrUnsupportedType so clients can use errors.Is() #93

Merged
merged 2 commits into from
Jan 28, 2024

Conversation

alecsammon
Copy link
Contributor

Expose core.ErrUnsupportedType so clients can use errors.Is()

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5dca4c8) 90.73% compared to head (e6be2b3) 90.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #93   +/-   ##
=======================================
  Coverage   90.73%   90.73%           
=======================================
  Files          33       33           
  Lines        1479     1479           
=======================================
  Hits         1342     1342           
  Misses         93       93           
  Partials       44       44           
Flag Coverage Δ
unittests 90.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alecsammon alecsammon marked this pull request as ready for review January 16, 2024 11:11
@alecsammon
Copy link
Contributor Author

@ggicci - sorry had issues with my original PR: #90 and coverage.
Re-opened it and its now 🟢

Not sure if this is what you meant with:

Let's hide owl from the package users. We may create a name alias in httpin, e.g.
var ErrUnsupportedType = owl. ErrUnsupportedType

Let me know if you thought of it in a different way.

Thank you!

@alecsammon
Copy link
Contributor Author

@ggicci - what are your thoughts about this change? Would be great for us if it could be merged and unblock us upgrading to the latest version.

Thanks!

@ggicci
Copy link
Owner

ggicci commented Jan 27, 2024

It looks good to me. I will update ASAP.

@ggicci ggicci merged commit af34b7c into ggicci:main Jan 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants