SYCL: Add all missing unary kernels #13074
Open
+191
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ggml
Alcpz
reviewed
Apr 23, 2025
AD2605
reviewed
Apr 23, 2025
Alcpz
approved these changes
Apr 24, 2025
qnixsynapse
force-pushed
the
sycl/unary_all
branch
3 times, most recently
from
dd0b15f to
beed9b3
Compare
Rbiessy
reviewed
Apr 25, 2025
ggml/src/ggml-sycl/element_wise.cpp
Outdated
Comment on lines
4
to
7
| #include <sycl/detail/builtins/builtins.hpp> | ||
| #include <sycl/nd_item.hpp> | ||
| #include <sycl/nd_range.hpp> | ||
| #include <sycl/range.hpp> |
There was a problem hiding this comment.
Why is the first header used? We should avoid relying on detail includes if possible.
It is more common to just include <sycl/sycl.hpp>. They could also all be removed if you're happy to rely on previous includes.
There was a problem hiding this comment.
Right. These includes gets auto imported by neovim editor. I need to disable autoimport in nvim-lsp.
Will remove it tomorrow.
qnixsynapse
force-pushed
the
sycl/unary_all
branch
from
beed9b3 to
bafafc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing absolute, ELU and SGN kernels.
test-backend-ops is passing with this change.
Note: Instead of doing
item_ct1.get_local_range(2) * item_ct1.get_group(2) + item_ct1.get_local_id(2);as with how it has been for rest of it, I diditem_ct1.get_global_id(2)for getting the idx position of an element here since operation of each element is independent of each other. Will be happy to hear thoughts about this.