-
Notifications
You must be signed in to change notification settings - Fork 13.2k
Fix thinking blocks with quotes + add handling [THINK]...[/THINK]
blocks
#16326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix thinking blocks with quotes + add handling [THINK]...[/THINK]
blocks
#16326
Conversation
Solve #16299 |
@ServeurpersoCom i've added fix for #16158 in ServeurpersoCom/pull/1 to your branch. Please review it and if all is good on your end, please merge it so that we can use this PR for solving both issues at once. |
…h-quotes' into fix-thinking-block-issues
@ServeurpersoCom CI has failed for Storybook tests, here's a fix — ServeurpersoCom#2 |
I've tested the changes across multiple models, including GPT-OSS, Seed-OSS, Qwen3*Thinking, and the Llama-3.3-Nemotron-Super-49B. I didn't observe any regressions or CoT (Chain-of-Thought) rendering issues : everything looks stable. |
Fix Chat Message Storybook story
[THINK]...[/THINK]
blocks
This patch did not fix it for me, b6653 still does not show the thought process. I run GLM 4.5, "unsloth dynamic quant", tried with |
I already have a test instance running with this model (Same for GLM 4.5 Air from Unsloth), and I can reproduce the same issue. I’ll take a closer look as soon as possible. |
it seems that GLM chat template is broken, because with Qwen 2.5 the thought process is displayed (although "◁think▷" tags are not stripped) |
#16364 addresses the |
Oh, so it’s just the missing line break for <think>...! 😲 |
Tested with GLM-4.5 inline <think> streaming (no line breaks, unlike Qwen). ![]() It still needs review and no-regression testing across all models: (I set up a dedicated machine with available for live WebUI tests |
I've merged this commit into #16364. @ServeurpersoCom lemme know once you've tested this thoroughly and if I can be of any more help with this. |
Close #16158
Close #16299