Skip to content

ggml : fix interpolate with align-corners and ne=1 #16700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ggml : fix interpolate with align-corners and ne=1 #16700

wants to merge 2 commits into from
+29 −36

Conversation

Acly
Copy link
Collaborator

@Acly Acly commented Oct 21, 2025

  • Avoid division by zero if one of the spatial dimensions is 1
  • Not unlikely to run into this for vision models that support dynamic resolution input and do some downscale steps
  • CPU, CUDA, OpenCL returned correct results anyway due to clamp, but I think it's still better to not div-by-zero
  • Vulkan didn't clamp, so results were broken. I removed the specialization for align-corners rather than adding more complex pipeline selection and fallback behavior.

@Acly
ggml : fix interpolate with align-corners and ne=1
7909346 
* avoid division by zero if one of the spatial dimensions is 1
* cpu, cuda, opencl returned correct result anyway due to clamp
* vulkan didn't clamp for align-corners so results were broken
@github-actions github-actions bot added testing Everything test related Nvidia GPU Issues specific to Nvidia GPUs Vulkan Issues specific to the Vulkan backend ggml changes relating to the ggml tensor library for machine learning OpenCL Issues specific to the OpenCL backend labels Oct 21, 2025
ggerganov
ggerganov approved these changes Oct 22, 2025
View reviewed changes
Copy link
Member

@ggerganov ggerganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack on the CPU change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggerganov ggerganov ggerganov approved these changes

@slaren slaren Awaiting requested review from slaren slaren is a code owner

@0cc4m 0cc4m Awaiting requested review from 0cc4m 0cc4m is a code owner

@lhez lhez Awaiting requested review from lhez lhez is a code owner

@max-krasnyansky max-krasnyansky Awaiting requested review from max-krasnyansky max-krasnyansky is a code owner

Assignees

No one assigned

Labels

ggml changes relating to the ggml tensor library for machine learning Nvidia GPU Issues specific to Nvidia GPUs OpenCL Issues specific to the OpenCL backend testing Everything test related Vulkan Issues specific to the Vulkan backend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Acly @ggerganov