Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed packages version problem + fixed problem with convert-hf-to-gguf-update.py #7925

Closed
wants to merge 1 commit into from

Conversation

hamdoudhakem
Copy link
Contributor

This PR make minor changes ro a few things including the version of some packages :

  • numpy : because it used deprecated python code that broke when installing the requirements.txt
  • torch : because it kept saying that the version 2.1.1 didn't exist and proposed other versions like 2.2.0, 2.2.1, etc

and also the convert-hf-to-gguf-update.py was updated to use encoding="utf-8" when reading and writing on convert-hf-to-gguf.py because some characters kept breaking the execution of the convert-hf-to-gguf-update.py (mostly hexadecimal characters that weren't recognized under windows default encoding) like the rocket emojis "🚀"

  • Self Reported Review Complexity:
    • Review Complexity : Low
    • Review Complexity : Medium
    • Review Complexity : High
  • I have read the contributing guidelines

-Changed the numby and torch versions to newer ones
- Specified the encoding when reading and writing on the convert-hf-to-gguf.py file from the convert-hf-to-gguf-update.py file
@github-actions github-actions bot added the python python script changes label Jun 13, 2024
@mofosyne mofosyne added the Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix label Jun 18, 2024
@Galunid
Copy link
Collaborator

Galunid commented Jun 19, 2024

Could you split it into 2 separate PRs? One for requirements other for encoding. I tested dependency bump and it seems to work both on python 3.11 and python 3.12, so looks like we're good there. Please ping me if/when you open them so I'll approve them quicker.

@hamdoudhakem
Copy link
Contributor Author

hamdoudhakem commented Jun 20, 2024

Could you split it into 2 separate PRs? One for requirements other for encoding. I tested dependency bump and it seems to work both on python 3.11 and python 3.12, so looks like we're good there. Please ping me if/when you open them so I'll approve them quicker.

I created 2 new PRs like you suggested here are the links :

@Galunid
Copy link
Collaborator

Galunid commented Jun 20, 2024

Thanks, I merged them, so we can close this one.

@Galunid Galunid closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python python script changes Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants