Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#70) housework select #73

Merged
merged 15 commits into from
Oct 18, 2023
Merged

feat(#70) housework select #73

merged 15 commits into from
Oct 18, 2023

Conversation

ghdcksgml1
Copy link
Owner

@ghdcksgml1 ghdcksgml1 commented Oct 17, 2023 •
edited
Loading

작업 내용

  • 조회 구현
  • 조회 캐싱 구현

테스트

  • INFO에 저장되어 있지만, 반영되지 않은 TODO는 생성된다.
  • INFO에 저장되어 있으면서, 반영되어 있는 TODO는 생성되지 않는다.
  • 캐싱되어 있는 데이터가 있으면 그대로 가져와 리턴한다.
  • 캐싱되어 있는 데이터가 있지만, dirtyBit가 true라면 HOUSEWORK_TODO를 최신화 시켜 캐싱한다.



리뷰 중점사항

  • heachi-support:common 모듈에 CachingStrategy 클래스의 cachingIfEmpty 어떻게 사용했는지 확인하기
  • QueryDsl 부분 참고해주세요. (fetchJoin을 쓴 이유 생각해보기)



관련 이슈

#70

@ghdcksgml1 ghdcksgml1 requested a review from jusung-c October 17, 2023 14:32
@ghdcksgml1 ghdcksgml1 linked an issue Oct 18, 2023 that may be closed by this pull request
feat: 집안일 조회 #70
Closed
2 tasks
@ghdcksgml1 ghdcksgml1 merged commit 0bbeae2 into dev Oct 18, 2023
1 check passed
@jusung-c
Copy link
Collaborator

드디어 이 코드들이 이해가 가네요 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jusung-c jusung-c Awaiting requested review from jusung-c

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: 집안일 조회
2 participants
@ghdcksgml1 @jusung-c