Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(#69) housework add #74

Merged
merged 41 commits into from
Oct 21, 2023
Merged

Feat(#69) housework add #74

merged 41 commits into from
Oct 21, 2023

Conversation

jusung-c
Copy link
Collaborator

@jusung-c jusung-c commented Oct 17, 2023 •
edited
Loading

  • Housework Add API 구현

  • Housework Add API 테스트

    • Controller Test
      • 집안일 추가 성공 테스트
      • 집안일 추가 실패 테스트
    • Service Test
      • 집안일 추가 성공 테스트
      • 집안일 추가 실패 테스트
    • Repository Test
      • HOUSEWORK_INFO save 테스트

    Service Test의 Auth 서버로 외부 요청 보내는 부분 아직 이해 못해서 못했습니다

    rebase 잘못해서 첨부터 다시 짰서요;
    커밋 로그 더러워진 점 이해 부탁드립니다..

jusung-c and others added 30 commits October 15, 2023 00:23
@jusung-c
feat(#69): HouseworkInfo Add API에 필요한 DTO 추가
4ff2d47
@jusung-c
feat(#69): DTO 수정 & Exception 관리
ddf6f60
@ghdcksgml1
move(#70): QueryDsl을 domain 모듈에서 구현하기 위해 위치 변경
3dba618
@ghdcksgml1
refactor(#70): 환경변수로 baseUrl을 지정하기 위해 값 변경
efbaaeb
@ghdcksgml1
feat(#70): 날짜 계산과 캐싱에 필요한 유틸 추가
ea2df08
@ghdcksgml1
feat(#70): email과 HOUSEWORK_INFO_ID로 그룹멤버 여부를 확인하는 쿼리 작성
f4036b1
@ghdcksgml1
feat(#70): 유저 인증 로직 구현
febb83a
@jusung-c
feat(#69): Housework Add API 구현
c6675fc
@ghdcksgml1
refactor(#70): Date 타입 변경
fe54bd1
@ghdcksgml1
refactor(#70): Date 타입 변경
73fd3fe
@jusung-c
(#69): 임시 커밋
490cf39
@jusung-c
feat(#69): HouseworkInfo Add API에 필요한 DTO 추가
33e68b0
@jusung-c
feat(#69): DTO 수정 & Exception 관리
4d18d7d
@jusung-c
feat(#69): Housework Add API 구현
84f3a47
@jusung-c
(#69): 임시 커밋
2af08de
@jusung-c
Merge remote-tracking branch 'upstream/feat(#69)-housework-add' into …
f1a7dcc 
…feat(#69)-housework-add
@jusung-c
feat(#69): Housework Add API 구현 수정
c9f41bf
@ghdcksgml1
test(#70): 테스트 세팅
7f791cf
@ghdcksgml1
feat(#70): Todo 조회
5ab6745
@ghdcksgml1
test(#70): Todo 테스트 코드
7fb0717
@ghdcksgml1
feat(#70): Redis에 캐싱할 TodoList 객체 정의
08b5057
@jusung-c
feat(#69): HouseworkInfo Add API에 필요한 DTO 추가
9f26fd6
@jusung-c
feat(#69): DTO 수정 & Exception 관리
5809435
@jusung-c
feat(#69): Housework Add API 구현
5c112b6
@jusung-c
(#69): 임시 커밋
66326b1
@jusung-c
feat(#69): Housework Add API 구현
cd8900d
@jusung-c
(#69): 임시 커밋
27dc249
@jusung-c
feat(#69): Housework Add API 구현 수정
bbc0987
@jusung-c
Merge remote-tracking branch 'upstream/feat(#69)-housework-add' into …
5a26d09 
…feat(#69)-housework-add
@jusung-c
test(#69): Housework Add API 테스트
f8cddf8
@ghdcksgml1
Copy link
Owner

가장 먼저 집안일 추가가 결국 HouseworkInfo를 만드는거기 때문에 HouseworkController => HouseworkInfoController로 바꿔야할 것 같습니다!

ghdcksgml1
ghdcksgml1 reviewed Oct 17, 2023
View reviewed changes
Copy link
Owner

@ghdcksgml1 ghdcksgml1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일단 리뷰 남겼습니다!
로직 부분에서 고쳐할점이 좀 있어서 내일 같이 해봅시다 😁

heachi-core/housework-api/src/main/java/com/heachi/housework/api/service/HouseworkService.java Outdated Show resolved Hide resolved
...rk-api/src/main/java/com/heachi/housework/api/controller/request/HouseworkAddRequestDTO.java Outdated Show resolved Hide resolved
...-api/src/main/java/com/heachi/housework/api/controller/response/HouseworkAddResponseDTO.java Outdated Show resolved Hide resolved
...ore/housework-api/src/main/java/com/heachi/housework/api/controller/HouseworkController.java Outdated Show resolved Hide resolved
...ore/housework-api/src/main/java/com/heachi/housework/api/controller/HouseworkController.java Outdated Show resolved Hide resolved
heachi-core/housework-api/src/main/java/com/heachi/housework/api/service/HouseworkService.java Outdated Show resolved Hide resolved
heachi-core/housework-api/src/main/java/com/heachi/housework/api/service/HouseworkService.java Outdated Show resolved Hide resolved
heachi-core/housework-api/src/main/java/com/heachi/housework/api/service/HouseworkService.java Outdated Show resolved Hide resolved
heachi-core/housework-api/src/main/java/com/heachi/housework/api/service/HouseworkService.java Outdated Show resolved Hide resolved
ghdcksgml1
ghdcksgml1 reviewed Oct 18, 2023
View reviewed changes
Copy link
Owner

@ghdcksgml1 ghdcksgml1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

피드백 부분 수정 부탁드립니다~

heachi-core/auth-api/src/main/java/com/heachi/auth/api/service/token/RefreshTokenService.java Outdated Show resolved Hide resolved
heachi-core/housework-api/build.gradle Outdated Show resolved Hide resolved
...rc/main/java/com/heachi/housework/api/controller/housework/info/HouseworkInfoController.java Outdated Show resolved Hide resolved
...java/com/heachi/housework/api/controller/housework/info/request/HouseworkInfoAddRequest.java Outdated Show resolved Hide resolved
...-api/src/main/java/com/heachi/housework/api/service/housework/info/HouseworkInfoService.java Outdated Show resolved Hide resolved
...-api/src/main/java/com/heachi/housework/api/service/housework/info/HouseworkInfoService.java Outdated Show resolved Hide resolved
...-api/src/main/java/com/heachi/housework/api/service/housework/info/HouseworkInfoService.java Outdated Show resolved Hide resolved
...-api/src/main/java/com/heachi/housework/api/service/housework/info/HouseworkInfoService.java Outdated Show resolved Hide resolved
...-api/src/main/java/com/heachi/housework/api/service/housework/info/HouseworkInfoService.java Outdated Show resolved Hide resolved
...-api/src/main/java/com/heachi/housework/api/service/housework/info/HouseworkInfoService.java Outdated Show resolved Hide resolved
@jusung-c
refactor(#69): 코드 리팩토링 - 피드백 반영
669263d 
1. 불필요한 메서드 제거
2. 불필요한 의존성 설정 제거
3. HouseworkInfo Create API 경로 수정
4. 집안일은 모두가 추가할 수 있도록 수정
    - 기존에는 그룹장만 추가할 수 있도록 했었음
5. HouseCategory 조회 로직 추가
6. Create API이므로 return값 필요 없음 -> void
7. HouseworkInfoAdd -> CreateHouseworkInfo 메서드명 변경
@jusung-c
refactor(#69): 단일 조회를 반복하는 부분 IN 이용해 한번에 조회하도록 수정
2f41049
@jusung-c
test(#69): HouseworkInfoServiceTest
0b65104
@jusung-c
Copy link
Collaborator Author

테스트 @AfterEach로 레포지토리 데이터 삭제하는 거 연관관계 생각 안하고 순서 멋대로 적었다가 삽질했네요ㅠ
내일 면접 파이팅하시고 천천히 리뷰 부탁드립니다!!!

image

ghdcksgml1
ghdcksgml1 reviewed Oct 20, 2023
View reviewed changes
Copy link
Owner

@ghdcksgml1 ghdcksgml1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 남겼습니다~ 제가 조금 손봐놓을게용

...ore/housework-api/src/main/java/com/heachi/housework/api/controller/HouseworkController.java Outdated
@PostMapping("/add")
public JsonResult<HouseworkAddResponseDTO> houseworkAdd(
@RequestHeader(name = "Authorization") String token,
@RequestBody HouseworkAddRequestDTO request
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Valid 가 존재하지 않는데 Validation이 잘 걸리나요??

...-api/src/main/java/com/heachi/housework/api/service/housework/info/HouseworkInfoService.java Outdated Show resolved Hide resolved
...-api/src/main/java/com/heachi/housework/api/service/housework/info/HouseworkInfoService.java Outdated Show resolved Hide resolved
...src/main/java/com/heachi/mysql/define/group/member/repository/GroupMemberRepositoryImpl.java Outdated Show resolved Hide resolved
...-api/src/main/java/com/heachi/housework/api/service/housework/info/HouseworkInfoService.java Outdated Show resolved Hide resolved
@ghdcksgml1
Copy link
Owner

수정 해놨습니다~ 확인하시면 머지할게요~~

HOUSEWORK_PERIOD_DAY 일때 캐싱 Update 부분은 #70 내용이 아직 존재하지 않아서 머지되면 바로 추가하려고 합니다.

고생하셨습니다~ 😁😁😁😁😁

@ghdcksgml1 ghdcksgml1 merged commit e31793d into dev Oct 21, 2023
1 check passed
@ghdcksgml1 ghdcksgml1 linked an issue Oct 21, 2023 that may be closed by this pull request
feat: 집안일 추가 #69
Closed
4 tasks
@jusung-c jusung-c deleted the feat(#69)-housework-add branch November 4, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghdcksgml1 ghdcksgml1 ghdcksgml1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: 집안일 추가
2 participants
@jusung-c @ghdcksgml1