Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#76): housework group #83

Merged
merged 2 commits into from
Oct 30, 2023
Merged

feat(#76): housework group #83

merged 2 commits into from
Oct 30, 2023

Conversation

ghdcksgml1
Copy link
Owner

@ghdcksgml1 ghdcksgml1 commented Oct 21, 2023 •
edited
Loading

작업 내용

  • 그룹 생성에 필요한 정보 받기
  • 그룹을 생성하면 자동으로 그룹 가입코드[6자리] 생성 (재생성 메소드도 만들어놓기)
  • 그룹을 생성하는 유저가 자동으로 그룹장으로 임명
  • GROUP_MEMBER에 자동으로 ACCEPT 상태로 유저를 등록해줘야함.

테스트

  • 올바른 GroupInfoCreateServiceRequest를 넘기면, 요청한 유저가 관리자로 GroupInfo, GroupMember가 생성된다.
  • 존재하지 않는 유저 이메일일 경우, GroupInfo를 생성할 수 없다.



리뷰 중점사항



관련 이슈

#76

@ghdcksgml1 ghdcksgml1 linked an issue Oct 21, 2023 that may be closed by this pull request
feat: GROUP_INFO (그룹 만들기) API #76
Closed
4 tasks
@ghdcksgml1 ghdcksgml1 merged commit 7918129 into dev Oct 30, 2023
1 check passed
jusung-c
jusung-c reviewed Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@jusung-c jusung-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ghdcksgml1 ghdcksgml1 deleted the feat(#76)-housework-group branch October 31, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jusung-c jusung-c jusung-c left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: GROUP_INFO (그룹 만들기) API
2 participants
@ghdcksgml1 @jusung-c