Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(#94) group member request handling #97

Merged
merged 5 commits into from
Nov 4, 2023
Merged

Feat(#94) group member request handling #97

merged 5 commits into from
Nov 4, 2023

Conversation

jusung-c
Copy link
Collaborator

@jusung-c jusung-c commented Nov 3, 2023

작업 내용

  • 수락 or 거절 선택에 따른 그룹 가입 요청 핸들링 API 구현

테스트

  • 그룹 가입 요청자의 상태가 WAITING이 아닐 경우 예외가 발생한다.
  • 해당 그룹의 그룹장이 아닐 경우 예외가 발생한다.
  • status가 true일 경우 그룹 가입 요청이 승인되어 그룹 가입 요청자의 상태가 ACCEPT로 변경된다.
  • status가 false일 경우 그룹 가입 요청이 거절되어 그룹 가입 요청자의 상태가 WITHDRAW로 변경된다.

관련 이슈

#94

@jusung-c
Copy link
Collaborator Author

jusung-c commented Nov 3, 2023

image

ghdcksgml1
ghdcksgml1 reviewed Nov 3, 2023
View reviewed changes
Copy link
Owner

@ghdcksgml1 ghdcksgml1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이제 로직적인 부분은 피드백 할게 거의 없네요! ㅎㅎ

고생하셨습니다! 피드백부분 고치면 resolve 버튼 눌러주세요.

...in/java/com/heachi/housework/api/controller/group/info/request/GroupInfoRegisterRequest.java Outdated Show resolved Hide resolved
heachi-domain-mysql/src/main/java/com/heachi/mysql/define/group/member/GroupMember.java Outdated Show resolved Hide resolved
...sql/src/main/java/com/heachi/mysql/define/group/member/repository/GroupMemberRepository.java Show resolved Hide resolved
...c/main/java/com/heachi/mysql/define/group/member/repository/GroupMemberRepositoryCustom.java Show resolved Hide resolved
...src/main/java/com/heachi/mysql/define/group/member/repository/GroupMemberRepositoryImpl.java Outdated Show resolved Hide resolved
...src/main/java/com/heachi/mysql/define/group/member/repository/GroupMemberRepositoryImpl.java Outdated Show resolved Hide resolved
@jusung-c jusung-c requested a review from ghdcksgml1 November 3, 2023 14:18
ghdcksgml1
ghdcksgml1 approved these changes Nov 4, 2023
View reviewed changes
Copy link
Owner

@ghdcksgml1 ghdcksgml1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! ㅎㅎ

@ghdcksgml1 ghdcksgml1 merged commit 166833e into dev Nov 4, 2023
1 check passed
@jusung-c jusung-c deleted the feat(#94)-group-member-request-handling branch November 4, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghdcksgml1 ghdcksgml1 ghdcksgml1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jusung-c @ghdcksgml1