Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes validate() (and unit tests) when being invoked under the promise metaphor in failure scenarios #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes validate() (and unit tests) when being invoked under the promise metaphor in failure scenarios #21

wants to merge 2 commits into from

Conversation

robertbullen
Copy link

Fixes #18

@coveralls
Copy link

Coverage Status

Coverage increased (+5.2%) to 80.435% when pulling 1eb89fc on robertbullen:bugfix-18 into 86c7386 on ghdna:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CognitoExpress.validate()'s callback parameter is optional, but is blindly invoked for error conditions
2 participants
@robertbullen @coveralls