Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor python bindings #156

Merged
merged 126 commits into from
Mar 20, 2024
Merged

Refactor python bindings #156

merged 126 commits into from
Mar 20, 2024

Conversation

boeschf
Copy link
Collaborator

@boeschf boeschf commented Jan 25, 2024 •
edited
Loading

This is an amendment to Stefano's PR #151

  • Switch build backend from setuptools.build_meta back to scikit-build-core. This may be become flexible enough once PRs 564 and 565 in scikit-build-core are merged
  • updated the Python bindings for the unstructured grids according to the new refactored structure
  • a bunch of other minor changes

update:

  • recent changes in scikit-build-core (565) have been incorporated: this makes selecting GPU mode + GPU arch possible through environment variables
  • cmake has been updated to better deal with hip-clang (bumped minimum version)
  • CI workflows are refactored
  • updated readme
  • bumped git submodule versions

@stubbiali
Minor changes to pyproject.toml.
12efda9
@stubbiali
Move source files into src/, and keep Python and C++ files in separat…
6e9f6fe 
…e directories.
@stubbiali
Revert patch of rpath.
7fa9880
@stubbiali
Add CMakeLists.txt inside _pyghex/.
d4239fb
@stubbiali
Clean-up CMakeLists and make scikit-build-core take care of Python so…
f448efe 
…urce files.
@stubbiali
Switch to setuptools.
267145c
@stubbiali
Add black options.
8df0373
@stubbiali
Apply black to all Python files.
5df4729
@stubbiali
Refine setup.py.
4e847e2
@stubbiali
Use CamelCase names for classes.
c55486b
@stubbiali
Sort out imports.
3d73cf9
@stubbiali
Adapt tests.
dde1c84
@stubbiali
Fix missing import.
ba089c9
@stubbiali
Use from __future__ import annotations.
2ca8733
@stubbiali
Few improvements to annotations.
44d484d
@stubbiali
Provisionally update oomph submodule.
5271671
@stubbiali
Copy dependent shared libraries into distribution.
547eff0
@stubbiali
Attempt at fixing installation of shared libraries.
d0c2b28
@stubbiali
Another attempt at fixing installation of shared libraries.
84be4ae
@stubbiali
Split functions and classes into multiple modules.
0cd6162
@stubbiali
Rename field_descriptor() as make_field_descriptor().
778ec15
@stubbiali
Fix retrieval of strides.
40ef5e5
@stubbiali
Add support for AMD GPUs.
8b0aad0
@stubbiali
Add utility to create a context from MPI comm.
4cb6bc0
@stubbiali
setup.py: add support for GPU and transport backends.
312a2b8
@stubbiali
Exchange up to 13 fields simultaneously.
c656eca
@stubbiali
First attempt at supporting GPU in CMakeLists for bindings.
80e7174
@stubbiali
Fix typo.
52f6d9a
@stubbiali
Cosmetics.
077d5a7
@stubbiali
Refine support for GPU.
2321d33
@boeschf boeschf marked this pull request as ready for review February 1, 2024 10:05
havogt
havogt reviewed Mar 5, 2024
View reviewed changes
bindings/python/src/ghex/structured/regular/communication_object.py Outdated
@@ -0,0 +1,20 @@
#
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move everything from the regular package to a single module (regular.py). Or is there a good reason to split?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no good reason - is done

This was referenced Mar 20, 2024
Closed
Closed
@boeschf boeschf merged commit c85302c into ghex-org:master Mar 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@havogt havogt havogt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boeschf @havogt @stubbiali