Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user-supplied events for DLQ processing (GSI-1251) #149

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

TheByronHimes
Copy link
Member

Allow passing a user-supplied event to KafkaDLQSubsciber.process(), which will not run the process_dlq_event function. Instead, it runs the basic header validation, checks that the correlation IDs match in both the DLQ event and the user-supplied event, and then directly publishes the user-supplied event to the retry topic before committing the DLQ offset.

The CID check ensures we don't:

  • copy/paste the wrong event data if calling the api by hand
  • accidentally submit the same event data twice and effectively replace the following DLQ event with a duplicate of the previous

@TheByronHimes TheByronHimes requested a review from Cito January 13, 2025 09:59
@TheByronHimes TheByronHimes merged commit 536c1ee into main Jan 14, 2025
8 checks passed
@TheByronHimes TheByronHimes deleted the feature/dlq_direct_process_GSI-1251 branch January 14, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants