feat: to network modifier
#4524
Conversation
seia-soto
changed the title
to network modifier
|
Despite we marked it's not safe to add one more bit before, but it's still safe to use 31st bit given that we're treating the number as unsigned integer. > const buf = new Uint8Array(4)
undefined
> buf.length
4
> buf[0] = (1 << 31) >>> 24
128
> buf
Uint8Array(4) [ 128, 0, 0, 0 ]
> (buf[0] << 24) >>> 0
2147483648 |
| for (const part of value.split('|')) { | ||
| if (option === 'to') { | ||
| if (part.charCodeAt(0) === 126 /* '~' */) { | ||
| denyallowEntities.add(part.slice(1)); | ||
| } else { | ||
| denyallowEntities.add(`~${part}`); | ||
| } | ||
| } else { | ||
| denyallowEntities.add(part); | ||
| } | ||
| } |
There was a problem hiding this comment.
Maybe this would be best handled inside of Domains directly. Maybe with a flag?
There was a problem hiding this comment.
The second argument of "Domain" is "debug = false". I don't know if it's still straightforward to have a third argument after this. There's no reason not to do that but need to find how to do that cleanly.
There was a problem hiding this comment.
Adding an argument is only one way to go about it that does not change the main comment. You can also use static method, etc.
There was a problem hiding this comment.
I think this is duplicate of #4525 which is already being handled. I don't know which will be merged first but I believe we can put this off for a while.
This partially implements https://github.com/gorhill/uBlock/wiki/Static-filter-syntax#to.
In the documentation,
tois described as:However, we already support entity-based syntax in
Domainsand only thing required is negation according to entity documentation: https://github.com/gorhill/uBlock/wiki/Static-filter-syntax#entityWe still don't support regular expression both in
domainanddenyallowoptions. Same goes forto:*$to=~/regex.../.denyallowwith uBo: ✅ negation and listing ❌ entities ❌ regextowith uBo: ✅ negation and listing ✅ entities ✅ regexdenyallow,towith Ghostery: ✅ negation and listing ✅ entities ❌ regexThis PR negates all hostnames in parse-time to flip the behavior of
denyallowwhentois detected.Also, rejects to parse filter having both
denyallowandtosince both are not likely to be used together.We can merge multiple domains then make it work but then we'll require extra space that allows us to determine which hostname is for
toanddenyallowwhen runningtoString.This PR also fixes
denyallowdomain list not being printed in a correct format fromtoStringmethod. There's a same regression intoStringregrading other network modifiers utilizingDomainslikefromand planned to fix in separate PR.