Support Node 18 without the need to use NODE_OPTIONS=--openssl-legacy-provider #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-classen
changed the title
Background for the changes:
* replace `{ fs: 'empty' }` by `resolve: { fallback: { fs: false } }`
* https://stackoverflow.com/a/64392550/783510
* hard-source-webpack-plugin is incompatible with webpack 5; instead
webpack 5 added native caching, which is automatically enabled in
development mode:
* mzgoddard/hard-source-webpack-plugin#546 (comment)
* https://webpack.js.org/configuration/cache/#cache
chrmod
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes Node 18 in list of supported NodeJs versions. Out of the box, the build did not work with Node 18 unless
--openssl-legacy-provideris used. An upgrade to webpack 5 fixed that.Background for the webpack changes:
replace
{ fs: 'empty' }byresolve: { fallback: { fs: false } }hard-source-webpack-plugin is incompatible with webpack 5; instead
webpack 5 added native caching, which is automatically enabled in
development mode:
compiler.hookscan not add property mzgoddard/hard-source-webpack-plugin#546 (comment)