Fix stats leakage #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@philipp-classen @smalluban please review commits in isolation and do not squash on merge. |
chrmod
force-pushed
the
fix-stats-leakage
branch
from
75025e9 to
33664aa
Compare
smalluban
approved these changes
Oct 12, 2023
| }, | ||
| } | ||
| }; | ||
| if (!global.crypto) { |
There was a problem hiding this comment.
As it is currently written (after the PR), the tests have the side effects to change
global.crypto === undefined (before tests) to global.crypto !== undefined (after tests)
chrmod
force-pushed
the
fix-stats-leakage
branch
2 times, most recently
from
8e3681d to
79e74d7
Compare
chrmod
force-pushed
the
fix-stats-leakage
branch
from
79e74d7 to
e2f148f
Compare
|
closing in favor of smaller PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR aims to prevent adblocker and anti-tracking stats "leaking" between navigations. Sadly the solution is not complete for Ghostery use-case as the same problem is also present in the Ghostery codebase.