gtk(wayland): implement server-sided decorations #4724
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcollie
suggested changes
Jan 6, 2025
| @@ -5780,6 +5780,27 @@ pub const BackgroundBlur = union(enum) { | |||
| } | |||
| }; | |||
|
|
|||
| /// See window-decoration | |||
| pub const WindowDecoration = enum { | |||
| true, | |||
There was a problem hiding this comment.
I think that it would be better to call this client and have parseCLI below translate true => client.
There was a problem hiding this comment.
That wouldn't really make sense on macOS, though
| pub const WindowDecoration = enum { | ||
| true, | ||
| server, | ||
| false, |
There was a problem hiding this comment.
Same as true above, except call it none. This matches the protocol more directly.
pluiedev
force-pushed
the
push-xlsyxlkuzpqk
branch
4 times, most recently
from
4c235dd to
7eaed4c
Compare
pluiedev
force-pushed
the
push-xlsyxlkuzpqk
branch
from
7eaed4c to
8216fce
Compare
pluiedev
force-pushed
the
push-xlsyxlkuzpqk
branch
from
8216fce to
0eed411
Compare
mitchellh
added a commit
that referenced
this pull request
Jan 10, 2025
There's one behavioral change here. Before this patch, if `gtk-titlebar=false` we _never_ created a headerbar. This explicitly contradicted the comments in the source, and the documentation for `gtk-titlebar` imply that if a window starts out without a titlebar it can be brought back later with the `toggle_window_decorations` keybind action. After this patch, a headerbar is always created, but if `gtk-titlebar=false` or `window-decoration=false` it's immediately hidden. I'm not sure how this interacts with the current SSD/CSD detection that seems to happen when running Ghostty on non-Gnome DEs so it'll be important to get #4724 merged (plus any follow ups) to enable more explicit control of SSD/CSD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4630 fully unless there exists an X11 API I haven't found yet :p
Depends on first commit of #4723, which is duplicated here for now