gtk(wayland): customize keyboard interactivity for quick terminal #7477
Conversation
pluiedev
force-pushed
the
push-rxnmykkmlykt
branch
from
02ab098 to
b929906
Compare
There was a problem hiding this comment.
Looks good to me. It's a bit of an odd configuration to expose since I'm not sure I see a use case for setting the other values but I'm fine with it, can always reassess later. More configurability is better than less to keep folks happy, especially if its minimal impact like this.
I made one comment to look at but no need for it to block this merge.
|
AFAICT on demand mode has some strange behavior on wlroots-based compositors like Sway, and so for them exclusive would work a bit better. It's been a while since I've used it, though. FWIW in my experience both Niri and KWin exhibit what is "correct" in my experience - |
This shouldn't be a real problem anymore since as of now (May 2025) all major compositors support at least version 4, but let's do this just in case.
It was getting a bit too unwieldy.
Even though gtk4-layer-shell's documentation claims that "nobody quite knows what it's for", some compositors (like Niri) can define custom rules based on the layer name and it's beneficial in those cases to define a distinct name just for our quick terminals.
pluiedev
force-pushed
the
push-rxnmykkmlykt
branch
from
b929906 to
6959fa8
Compare
|
Looks good to me. |
Fixes #7476