-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added plotly support and other fixes to plotting functions #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge with upstream v2.2-61
Update from new release (v2.3-00)
* fixed issue with ICERs not plottable with plotly * fixed issue with points cloud not resizable with plotly * added comparison label to ICER points with plotly * fixed issue with legend positions in corners (eg topleft) with ggplot * added different default values in prep_ceplane_params with plotly, passing the graph parameter to the function
* fixed bug in "right" legend positioning * added labels to ICER legends
hopefully for the last time
* removed linewidth from ggplot version * fixed plotly version * changed default legend positioning to play nice with plotly
* added native plotly contour function * fixed bug where ggplot legend position could not be modified
* added contour2 plotly option * moved plotly contour lines to specialized function * moved prep delta_ce (long format BCEA object) to specialized function
Wrong argument passed as graph type
* Fixed issue when least effective intervention was not the cheapest: frontier set not to start from origins * Fixed issue subsetting the incorrect comparators in the non-efficient interventions table
Fix some partial matching
Note NAMESPACE might need to be manually edited to avoid the last_plot conflict between plotly and ggplot2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.