[Windows] Ignore disk I/O counters for drives that are not accessible #1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
force-pushed
the
mx-psi/permissions-issue
branch
2 times, most recently
from
2b117e7 to
21d7ce2
Compare
|
@giampaolo Would it be possible for you to have a look at this? Also, I wonder if I can have a timeline on when this or my previous PR #1961 will be in a released version of psutil. It would be awesome to be able to share a rough date with customers of my employer who need these fixes. Thanks in advance :) |
Signed-off-by: Pablo Baeyens <[email protected]>
mx-psi
force-pushed
the
mx-psi/permissions-issue
branch
from
adf1b82 to
5b8e9c2
Compare
|
@giampaolo friendly ping, could you have a look? |
Signed-off-by: Pablo Baeyens <[email protected]>
mx-psi
force-pushed
the
mx-psi/permissions-issue
branch
from
e0fb255 to
b35e8f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
disk_io_counters#1974Description
Ignore permission errors on Windows when fetching I/O counters. I would classify this as a bug fix since this error only happens because of the way the function works (by exhaustively checking every possible drive), and nothing in the function description indicates it should work like this.
Nonetheless I understand it is debatable (see proposed alternative on linked issue if this is not an acceptable patch).