add Secret resource #32
Conversation
helm/alloy/templates/secret.yaml
Outdated
| {{- if .Values.alloy.alloy.secret.content }} | ||
| {{- .Values.alloy.alloy.secret.content | nindent 2 }} | ||
| {{- else }} | ||
| {{- .Files.Get "config/example.secret" | nindent 2 }} |
There was a problem hiding this comment.
I would prefer that you require the .Values.alloy.alloy.secret.content to not be empty than provide an incorrect config though
There was a problem hiding this comment.
That's a good point so I did move the secret example into helm/alloy/examples/mimir-rules
|
I assume the secrets needs to be mounted via env variables? Could you add an example explaining how here? |
|
Also, please open the PR upstream as well to make sure this is supported in the long run |
Just did that in
Will do |
|
Submitted a PR upstream to add support for the Secret resource grafana/alloy#1502 Also updated this PR to align with the proposition made upstream. |
Towards: giantswarm/roadmap#3522
This PR adds a secret resource into the Alloy helm chart to allow passing secret configuration via helm values.