fix-alloy-vpa-value-usage #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuentinBisson
force-pushed
the
fix-alloy-vpa-value-usage
branch
from
cc62758
to
a7ba7c6
Compare
|
So I tested that the VPA was working but did not check the container policies :( |
QuentinBisson
commented
Sep 2, 2024
|
It has been tested multiple times with this PR giantswarm/prometheus-rules#1339 |
QuantumEnigmaa
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards: giantswarm/roadmap#358
This PR fixes the vpa value path and incorrect helm values around container policies
Checklist