Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused firestoreServiceAccountKey value #368

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

marians
Copy link
Member

@marians marians commented Jan 31, 2025

Towards https://github.com/giantswarm/giantswarm/issues/31025

The value is no longer used by athena itself and has been removed from configs, too.

Checklist

  • Update changelog in CHANGELOG.md.

@marians marians self-assigned this Jan 31, 2025
@marians marians requested a review from a team as a code owner January 31, 2025 11:06
@marians marians merged commit ba268c6 into main Feb 3, 2025
8 checks passed
@marians marians deleted the remove-firestore-credentials branch February 3, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants