Disable logger development mode to avoid panicking, use zap as logger #114
Conversation
| Scheme: scheme, | ||
| MetricsBindAddress: metricsAddr, | ||
| Port: 9443, | ||
| Scheme: scheme, |
There was a problem hiding this comment.
I did my best to make azure-private-endpoint-operator working again. when I changed zap Development flag it was not even building due to a lot of changes in controller-manager
| @@ -76,7 +77,7 @@ func (s *Service) ReconcileMcToWcApi(ctx context.Context) error { | |||
| // | |||
| for _, privateLink := range privateLinks { | |||
| logger.Info(fmt.Sprintf("Found private link %s", privateLink.Name)) | |||
| manualApproval := !slice.Contains(privateLink.AutoApprovedSubscriptions, s.privateEndpointsScope.GetSubscriptionID()) | |||
| manualApproval := !slice.Contains(util.ConvertToStringSlice(privateLink.AutoApprovedSubscriptions), s.privateEndpointsScope.GetSubscriptionID()) | |||
There was a problem hiding this comment.
I had to add a helper function converting privateLinks, because I had to update github.com/giantswarm/cluster-api-provider-azure
There's no native function included, that's why I had to come up with something
There was a problem hiding this comment.
private links are in github.com/giantswarm/cluster-api-provider-azure v1.12.4 pointer string slices
| @@ -64,11 +64,10 @@ func (s *Scope) LookupPrivateLink(privateLinkResourceID string) (capz.PrivateLin | |||
| func (s *Scope) GetPrivateLinksWithAllowedSubscription(managementClusterSubscriptionID string) []capz.PrivateLink { | |||
| var privateLinksWhereMCSubscriptionIsAllowed []capz.PrivateLink | |||
| for _, privateLink := range s.privateLinks { | |||
| if slice.Contains(privateLink.AllowedSubscriptions, managementClusterSubscriptionID) { | |||
| if util.ContainsPtr(privateLink.AllowedSubscriptions, managementClusterSubscriptionID) { | |||
There was a problem hiding this comment.
Same here, slice.Contains in azure-private-endpoint-operator but not Contains for Pointer
| @@ -6,8 +6,8 @@ import ( | |||
|
|
|||
| type PrivateLinkBuilder struct { | |||
| name string | |||
| allowedSubscriptions []string | |||
| autoApprovedSubscriptions []string | |||
| allowedSubscriptions []*string | |||
There was a problem hiding this comment.
This also needed to chang.
Unfortunately I had to make all the changes for one small change, the build was already failing before.
Towards: giantswarm/roadmap#3658