Cert-manager-app fixes #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anvddriesch
reviewed
Oct 26, 2023
| @@ -46,4 +46,4 @@ acme: | |||
| secretAccessKey: "" | |||
| http01: | |||
| enabled: true | |||
| ingressClassName: nginx | |||
| ingressClass: "" | |||
There was a problem hiding this comment.
For my intertest, what will be the outcome of removing the default?
Will it just result the solver ingresses to have no class or will they have the class of the original ingress? Could there be a negative outcome for cases in which other issuers/classes are defined?
There was a problem hiding this comment.
I came to the conclusion that this change to "" or default doesn't makes sense for now, as there may be no ingress controllers deployed by the time cert-manager is deployed
vvondruska
approved these changes
Oct 27, 2023
calvix
approved these changes
Oct 27, 2023
kopiczko
reviewed
Oct 30, 2023
| acme.cert-manager.io/http01-solver: "true" | ||
| policyTypes: | ||
| - Ingress | ||
| egress: |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
...anager/charts/cert-manager-giantswarm-netpol/templates/acme-solvers-ciliumnetworkpolicy.yaml
Outdated
Show resolved
Hide resolved
kopiczko
approved these changes
Oct 31, 2023
|
can we merge and release this? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
resolves #28598
Checklist