Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple-lb-ip-pool-in-wc #266

Merged
merged 16 commits into from
Sep 2, 2024
Merged

multiple-lb-ip-pool-in-wc #266

merged 16 commits into from
Sep 2, 2024

Conversation

vxav
Copy link
Contributor

@vxav vxav commented Aug 14, 2024

towards giantswarm/roadmap#3637

This pr: ..
ain't pretty and untested
adds the option to assign multiple lb ips

Trigger e2e tests

/run cluster-test-suites

@tinkerers-ci
Copy link

tinkerers-ci bot commented Aug 14, 2024

Note

As this is a draft PR no triggers from the PR body will be handled.

If you'd like to trigger them while draft please add them as a PR comment.

@anvddriesch
Copy link
Contributor

/run cluster-test-suites

@anvddriesch
Copy link
Contributor

/run cluster-test-suites

@tinkerers-ci
Copy link

tinkerers-ci bot commented Aug 21, 2024

Oh No! 😱 At least one test suite has failed during the AfterSuite cleanup stage and might have left around some resources on the MC!

Be sure to check the full results in Tekton Dashboard to see which test suite has failed and then run the following on the associated MC to list all leftover resources:

PIPELINE_RUN="pr-cluster-vsphere-266-cluster-test-suitesz45wb"

NAMES="$(kubectl api-resources --verbs list -o name | tr '\n' ,)"
kubectl get "${NAMES:0:${#NAMES}-1}" --show-kind --ignore-not-found -l cicd.giantswarm.io/pipelinerun=${PIPELINE_RUN} -A 2>/dev/null

@tinkerers-ci
Copy link

tinkerers-ci bot commented Aug 21, 2024

cluster-test-suites

Run name pr-cluster-vsphere-266-cluster-test-suitesz45wb
Commit SHA 93c6dbe
Result Failed ❌

📋 View full results in Tekton Dashboard

Rerun trigger:
/run cluster-test-suites


Tip

To only re-run the failed test suites you can provide a TARGET_SUITES parameter with your trigger that points to the directory path of the test suites to run, e.g. /run cluster-test-suites TARGET_SUITES=./providers/capa/standard to re-run the CAPA standard test suite. This supports multiple test suites with each path separated by a comma.

@tinkerers-ci
Copy link

tinkerers-ci bot commented Aug 21, 2024

Oh No! 😱 At least one test suite has failed during the AfterSuite cleanup stage and might have left around some resources on the MC!

Be sure to check the full results in Tekton Dashboard to see which test suite has failed and then run the following on the associated MC to list all leftover resources:

PIPELINE_RUN="pr-cluster-vsphere-266-cluster-test-suitesmjzm9"

NAMES="$(kubectl api-resources --verbs list -o name | tr '\n' ,)"
kubectl get "${NAMES:0:${#NAMES}-1}" --show-kind --ignore-not-found -l cicd.giantswarm.io/pipelinerun=${PIPELINE_RUN} -A 2>/dev/null

@tinkerers-ci
Copy link

tinkerers-ci bot commented Aug 21, 2024

cluster-test-suites

Run name pr-cluster-vsphere-266-cluster-test-suitesmjzm9
Commit SHA 345e6b3
Result Failed ❌

📋 View full results in Tekton Dashboard

Rerun trigger:
/run cluster-test-suites


Tip

To only re-run the failed test suites you can provide a TARGET_SUITES parameter with your trigger that points to the directory path of the test suites to run, e.g. /run cluster-test-suites TARGET_SUITES=./providers/capa/standard to re-run the CAPA standard test suite. This supports multiple test suites with each path separated by a comma.

@anvddriesch
Copy link
Contributor

/run cluster-test-suites TARGET_SUITES=./providers/capv/standard

@tinkerers-ci
Copy link

tinkerers-ci bot commented Aug 22, 2024

cluster-test-suites

Run name pr-cluster-vsphere-266-cluster-test-suitesbfrqw
Commit SHA 70c23ce
Result Failed ❌

📋 View full results in Tekton Dashboard

Rerun trigger:
/run cluster-test-suites


Tip

To only re-run the failed test suites you can provide a TARGET_SUITES parameter with your trigger that points to the directory path of the test suites to run, e.g. /run cluster-test-suites TARGET_SUITES=./providers/capa/standard to re-run the CAPA standard test suite. This supports multiple test suites with each path separated by a comma.

@anvddriesch
Copy link
Contributor

/run cluster-test-suites TARGET_SUITES=./providers/capv/standard

@tinkerers-ci
Copy link

tinkerers-ci bot commented Aug 22, 2024

cluster-test-suites

Run name pr-cluster-vsphere-266-cluster-test-suiteswnn9k
Commit SHA 70c23ce
Result Failed ❌

📋 View full results in Tekton Dashboard

Rerun trigger:
/run cluster-test-suites


Tip

To only re-run the failed test suites you can provide a TARGET_SUITES parameter with your trigger that points to the directory path of the test suites to run, e.g. /run cluster-test-suites TARGET_SUITES=./providers/capa/standard to re-run the CAPA standard test suite. This supports multiple test suites with each path separated by a comma.

@anvddriesch
Copy link
Contributor

/run cluster-test-suites TARGET_SUITES=./providers/capv/standard

@tinkerers-ci
Copy link

tinkerers-ci bot commented Aug 22, 2024

cluster-test-suites

Run name pr-cluster-vsphere-266-cluster-test-suitesdfxtm
Commit SHA bd0927b
Result Failed ❌

📋 View full results in Tekton Dashboard

Rerun trigger:
/run cluster-test-suites


Tip

To only re-run the failed test suites you can provide a TARGET_SUITES parameter with your trigger that points to the directory path of the test suites to run, e.g. /run cluster-test-suites TARGET_SUITES=./providers/capa/standard to re-run the CAPA standard test suite. This supports multiple test suites with each path separated by a comma.

@anvddriesch
Copy link
Contributor

/run cluster-test-suites TARGET_SUITES=./providers/capv/standard

@tinkerers-ci
Copy link

tinkerers-ci bot commented Aug 22, 2024

cluster-test-suites

Run name pr-cluster-vsphere-266-cluster-test-suitest4bcd
Commit SHA a94e4ad
Result Completed ✅

📋 View full results in Tekton Dashboard

Rerun trigger:
/run cluster-test-suites


Tip

To only re-run the failed test suites you can provide a TARGET_SUITES parameter with your trigger that points to the directory path of the test suites to run, e.g. /run cluster-test-suites TARGET_SUITES=./providers/capa/standard to re-run the CAPA standard test suite. This supports multiple test suites with each path separated by a comma.

@anvddriesch anvddriesch self-assigned this Aug 26, 2024
@tinkerers-ci
Copy link

tinkerers-ci bot commented Aug 26, 2024

cluster-test-suites

Run name pr-cluster-vsphere-266-cluster-test-suiteslsgnv
Commit SHA 2c4636d
Result Failed ❌

📋 View full results in Tekton Dashboard

Rerun trigger:
/run cluster-test-suites


Tip

To only re-run the failed test suites you can provide a TARGET_SUITES parameter with your trigger that points to the directory path of the test suites to run, e.g. /run cluster-test-suites TARGET_SUITES=./providers/capa/standard to re-run the CAPA standard test suite. This supports multiple test suites with each path separated by a comma.

@anvddriesch
Copy link
Contributor

/run cluster-test-suites

@tinkerers-ci
Copy link

tinkerers-ci bot commented Aug 26, 2024

cluster-test-suites

Run name pr-cluster-vsphere-266-cluster-test-suitesszzbb
Commit SHA 2c4636d
Result Failed ❌

📋 View full results in Tekton Dashboard

Rerun trigger:
/run cluster-test-suites


Tip

To only re-run the failed test suites you can provide a TARGET_SUITES parameter with your trigger that points to the directory path of the test suites to run, e.g. /run cluster-test-suites TARGET_SUITES=./providers/capa/standard to re-run the CAPA standard test suite. This supports multiple test suites with each path separated by a comma.

@anvddriesch
Copy link
Contributor

/run cluster-test-suites

@anvddriesch anvddriesch marked this pull request as ready for review August 28, 2024 09:37
@anvddriesch anvddriesch requested a review from a team as a code owner August 28, 2024 09:37
@tinkerers-ci
Copy link

tinkerers-ci bot commented Aug 28, 2024

cluster-test-suites

Run name pr-cluster-vsphere-266-cluster-test-suitesjvjpr
Commit SHA 4dbe1d0
Result Failed ❌

📋 View full results in Tekton Dashboard

Rerun trigger:
/run cluster-test-suites


Tip

To only re-run the failed test suites you can provide a TARGET_SUITES parameter with your trigger that points to the directory path of the test suites to run, e.g. /run cluster-test-suites TARGET_SUITES=./providers/capa/standard to re-run the CAPA standard test suite. This supports multiple test suites with each path separated by a comma.

@anvddriesch
Copy link
Contributor

/run cluster-test-suites TARGET_SUITES=./providers/capv/on-capz

@tinkerers-ci
Copy link

tinkerers-ci bot commented Aug 29, 2024

cluster-test-suites

Run name pr-cluster-vsphere-266-cluster-test-suitesqw8nf
Commit SHA 4dbe1d0
Result Completed ✅

📋 View full results in Tekton Dashboard

Rerun trigger:
/run cluster-test-suites


Tip

To only re-run the failed test suites you can provide a TARGET_SUITES parameter with your trigger that points to the directory path of the test suites to run, e.g. /run cluster-test-suites TARGET_SUITES=./providers/capa/standard to re-run the CAPA standard test suite. This supports multiple test suites with each path separated by a comma.

@anvddriesch
Copy link
Contributor

/run cluster-test-suites

@anvddriesch anvddriesch enabled auto-merge (squash) August 29, 2024 10:55
@tinkerers-ci
Copy link

tinkerers-ci bot commented Aug 29, 2024

cluster-test-suites

Run name pr-cluster-vsphere-266-cluster-test-suites7h2gr
Commit SHA 4dbe1d0
Result Failed ❌

📋 View full results in Tekton Dashboard

Rerun trigger:
/run cluster-test-suites


Tip

To only re-run the failed test suites you can provide a TARGET_SUITES parameter with your trigger that points to the directory path of the test suites to run, e.g. /run cluster-test-suites TARGET_SUITES=./providers/capa/standard to re-run the CAPA standard test suite. This supports multiple test suites with each path separated by a comma.

@anvddriesch
Copy link
Contributor

metrics tests on gcapeverde are still failing for this one but it's unrelated

@anvddriesch
Copy link
Contributor

/run cluster-test-suites TARGET_SUITES=./providers/capv/on-capz

@tinkerers-ci
Copy link

tinkerers-ci bot commented Aug 29, 2024

cluster-test-suites

Run name pr-cluster-vsphere-266-cluster-test-suitesvglfm
Commit SHA 4dbe1d0
Result Failed ❌

📋 View full results in Tekton Dashboard

Rerun trigger:
/run cluster-test-suites


Tip

To only re-run the failed test suites you can provide a TARGET_SUITES parameter with your trigger that points to the directory path of the test suites to run, e.g. /run cluster-test-suites TARGET_SUITES=./providers/capa/standard to re-run the CAPA standard test suite. This supports multiple test suites with each path separated by a comma.

@anvddriesch
Copy link
Contributor

/run cluster-test-suites

@tinkerers-ci
Copy link

tinkerers-ci bot commented Sep 2, 2024

cluster-test-suites

Run name pr-cluster-vsphere-266-cluster-test-suites47dgx
Commit SHA 3f763ae
Result Failed ❌

📋 View full results in Tekton Dashboard

Rerun trigger:
/run cluster-test-suites


Tip

To only re-run the failed test suites you can provide a TARGET_SUITES parameter with your trigger that points to the directory path of the test suites to run, e.g. /run cluster-test-suites TARGET_SUITES=./providers/capa/standard to re-run the CAPA standard test suite. This supports multiple test suites with each path separated by a comma.

Copy link
Contributor

github-actions bot commented Sep 2, 2024

There were no differences in the rendered Helm template.

Output
=== Differences when rendered with values file helm/cluster-vsphere/ci/test-wc-values.yaml ===

No difference


=== No differences at all ===

@anvddriesch
Copy link
Contributor

/run cluster-test-suites TARGET_SUITES=./providers/capv/on-capz

@anvddriesch anvddriesch enabled auto-merge (squash) September 2, 2024 13:06
@anvddriesch
Copy link
Contributor

capz test still does not pass (the others do) but I don't see how it could be related to these changes. The ips are correctly assigned on capz as well.

@anvddriesch anvddriesch added the skip/ci Instructs pr-gatekeeper to ignore any required PR checks label Sep 2, 2024
@anvddriesch anvddriesch merged commit d7f7f3e into main Sep 2, 2024
13 of 14 checks passed
@anvddriesch anvddriesch deleted the multiple-lb-ip-pool-in-wc branch September 2, 2024 13:07
@tinkerers-ci
Copy link

tinkerers-ci bot commented Sep 2, 2024

cluster-test-suites

Run name pr-cluster-vsphere-266-cluster-test-suites57nl2
Commit SHA 6e305f9
Result Failed ❌

📋 View full results in Tekton Dashboard

Rerun trigger:
/run cluster-test-suites


Tip

To only re-run the failed test suites you can provide a TARGET_SUITES parameter with your trigger that points to the directory path of the test suites to run, e.g. /run cluster-test-suites TARGET_SUITES=./providers/capa/standard to re-run the CAPA standard test suite. This supports multiple test suites with each path separated by a comma.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/ci Instructs pr-gatekeeper to ignore any required PR checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants