Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use init-container to prepare /etc/hosts file for kube-vip #311

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

glitchcrab
Copy link
Member

let's try this to see if kube-vip works

kube-vip/kube-vip#692

@glitchcrab glitchcrab requested a review from a team as a code owner November 14, 2024 11:04
@glitchcrab glitchcrab self-assigned this Nov 14, 2024
Copy link
Contributor

@vxav vxav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

There were differences in the rendered Helm template, please check! ⚠️

Output
=== Differences when rendered with values file helm/cluster-vsphere/ci/test-wc-values.yaml ===

/stringData/content  (v1/Secret/release-name-kubevip-pod)
  ± value change in multiline text (one insert, no deletions)
    +   initContainers:
    +   - name: update-hosts-record
    +     image: gsoci.azurecr.io/giantswarm/busybox:1.37.0
    +     command: ["/bin/sh", "-c", "echo '127.0.0.1  kubernetes' >> /etc/hosts"]
  
  

@glitchcrab glitchcrab added the skip/ci Instructs pr-gatekeeper to ignore any required PR checks label Nov 14, 2024
@glitchcrab
Copy link
Member Author

CI tested locally, cluster creation is fixed

@glitchcrab glitchcrab merged commit 26ea2f1 into main Nov 14, 2024
10 checks passed
@glitchcrab glitchcrab deleted the fix/kubevip-hosts-file branch November 14, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/ci Instructs pr-gatekeeper to ignore any required PR checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants