Deprecate global.connectivity.network.allowAllEgress (#294)

giantswarm · Aug 9, 2024 · 7b1490d · 7b1490d
1 parent fbbe94e
commit 7b1490d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Changed
+
+- Deprecate usage of `.Values.global.connectivity.network.allowAllEgress`.
+
 ## [1.1.0] - 2024-08-07
 
 ### Added

diff --git a/helm/cluster/README.md b/helm/cluster/README.md
@@ -238,7 +238,7 @@ Configuration of connectivity and networking options.
 | `global.connectivity.bastion.enabled` | **Enable**|**Type:** `boolean`<br/>**Default:** `true`|
 | `global.connectivity.bastion.replicas` | **Number of hosts**|**Type:** `integer`<br/>**Default:** `1`|
 | `global.connectivity.network` | **Network**|**Type:** `object`<br/>|
-| `global.connectivity.network.allowAllEgress` | **Allow all egress**|**Type:** `boolean`<br/>**Default:** `false`|
+| `global.connectivity.network.allowAllEgress` | **Allow all egress (DEPRECATED)** - This flag has been deprecated. Currently the default value is false, which means that network-policies app will get installed. Setting this flag to true means that network-policies app is not installed, and that should not be done anymore.|**Type:** `boolean`<br/>**Default:** `false`|
 | `global.connectivity.network.pods` | **Pods**|**Type:** `object`<br/>|
 | `global.connectivity.network.pods.cidrBlocks` | **Pod subnets**|**Type:** `array`<br/>**Default:** `["100.64.0.0/12"]`|
 | `global.connectivity.network.pods.cidrBlocks[*]` | **Pod subnet** - IPv4 address range for pods, in CIDR notation.|**Type:** `string`<br/>**Example:** `"10.244.0.0/16"`<br/>|

diff --git a/helm/cluster/values.schema.json b/helm/cluster/values.schema.json
@@ -1372,7 +1372,8 @@
                             "properties": {
                                 "allowAllEgress": {
                                     "type": "boolean",
-                                    "title": "Allow all egress",
+                                    "title": "Allow all egress (DEPRECATED)",
+                                    "description": "This flag has been deprecated. Currently the default value is false, which means that network-policies app will get installed. Setting this flag to true means that network-policies app is not installed, and that should not be done anymore.",
                                     "default": false
                                 },
                                 "pods": {