Placeholder CI for automatically testing cluster chart changes in cluster-<provider> apps #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nprokopic
changed the title
nprokopic
changed the title
|
/run cluster-test-suites |
nprokopic
force-pushed
the
test-changes-in-cluster-provider
branch
from
7a1b981
to
3531fa2
Compare
nprokopic
changed the title
nprokopic
commented
Jul 11, 2024
| run: | | ||
| git clone https://github.com/giantswarm/cluster-aws.git | ||
|
|
||
| - name: Update cluster chart version in Chart.yaml |
There was a problem hiding this comment.
It's not really updating it, just prints theoretical version updates
|
There were no differences in the rendered Helm template. Output |
|
Will merge this and then open a PR with actual workflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a placeholder GitHub action (does not make any changes anywhere) to automate testing of cluster chart changes in cluster-aws.
In order to really test this, the GitHub workflow has to be in the main branch, so adding first a workflow that just prints theoretical cluster chart version update in cluster-aws.
Any background context you can provide?
CAPA is already GA, CAPZ will be GA soon, and all other providers will also soon start to use cluster chart, so without automated cross-provider testing the risk of issues slipping through cracks due to changes not being tested is very high.