-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.5.0 #354
Release v1.5.0 #354
Conversation
There were differences in the rendered Helm template, please check! Output
|
Hey @taylorbot, a test pull request has been created for you in the cluster-aws repo! Go to pull request giantswarm/cluster-aws#878 in order to test your cluster chart changes on AWS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how urgent this is, but can we maybe wait until #348 got merged? @fiunchinho, what's the current state of your work?
I'm currently blocked until this is released so it's quite urgent for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to unblock you, would have been a dream to also get Jose's work into this release though. 🙂
In the end it's just numbers. 🤪 |
I'd like an approval from someone from Phoenix before merging mine. I'll ping them. |
Thank you for responding! I hope you're fine with not having it included in the current release. We can still forge a v1.6.0 for your changes only then! 🙂 |
... on the other hand: If Wealdy waits a bit longer and Phoenix hurries up... 😅 |
I'm fine either way 🙂 I pinged phoenix people, but it's been a busy day so far. |
It's not a big deal to wait a little longer :) i'm using the test builds of the chart to do my testing in VCD so i can work on that until this is merged. |
I'm going to close this PR for now as I would like to get #355 into the same release too (as it extends the systemd options) |
No description provided.