Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not reconcile aws infrastructure clusters #244

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Do not reconcile aws infrastructure clusters #244

merged 1 commit into from
Aug 19, 2024

Conversation

anvddriesch
Copy link
Contributor

towards giantswarm/roadmap#3624

This PR:

  • disables reconciling AWSCluster type infra clusters. This is needed in order to support CAPV on CAPA hybrid environments and correctly handle CAPV dns while leaving CAPA alone.
  • in the future we can add flags that would allow us to enable or disable certain infrastructure types on MC basis if needed
  • we also push this to the capa-capv app collection now

Checklist

  • Update changelog in CHANGELOG.md.

@anvddriesch anvddriesch self-assigned this Aug 19, 2024
@anvddriesch anvddriesch requested a review from a team as a code owner August 19, 2024 09:01
Copy link
Member

@glitchcrab glitchcrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me :)

@anvddriesch anvddriesch merged commit d787e6d into main Aug 19, 2024
5 checks passed
@anvddriesch anvddriesch deleted the capa-capv branch August 19, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants