add role assumption option #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anvddriesch
commented
Oct 16, 2024
| @@ -21,7 +19,7 @@ type AWSClients struct { | |||
|
|
|||
| // NewRoute53Client creates a new Route53 API client for a given session | |||
| func NewRoute53Client(session cloud.Session, target runtime.Object) *route53.Route53 { | |||
| Route53Client := route53.New(session.Session(), &aws.Config{Credentials: credentials.NewSharedCredentials("", "")}) | |||
| Route53Client := route53.New(session.Session(), nil) | |||
There was a problem hiding this comment.
We want to use the credentials we already created for the session below in NewClusterScope
vxav
approved these changes
Oct 16, 2024
|
Makes sense. I will add a paragraph 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/giantswarm/giantswarm/issues/31705
This PR:
Checklist