update ats tests #229
update ats tests #229
Conversation
QuantumEnigmaa
force-pushed
the
update-ats-tests
branch
from
6153c21
to
f7e6219
Compare
QuantumEnigmaa
force-pushed
the
update-ats-tests
branch
from
f7e6219
to
415a8f5
Compare
QuantumEnigmaa
force-pushed
the
update-ats-tests
branch
from
268e2b9
to
011b7dd
Compare
|
All tests passing |
tests/ats/test_grafana.py
Outdated
| def test_api_working(kube_cluster: Cluster) -> None: | ||
| """Very minimalistic example of using the [kube_cluster](pytest_helm_charts.fixtures.kube_cluster) | ||
| fixture to get an instance of [Cluster](pytest_helm_charts.clusters.Cluster) under test | ||
| and access its [kube_client](pytest_helm_charts.clusters.Cluster.kube_client) property | ||
| to get access to Kubernetes API of cluster under test. | ||
| Please refer to [pykube](https://pykube.readthedocs.io/en/latest/api/pykube.html) to get docs | ||
| for [HTTPClient](https://pykube.readthedocs.io/en/latest/api/pykube.html#pykube.http.HTTPClient). | ||
| """ | ||
| assert kube_cluster.kube_client is not None | ||
| assert len(pykube.Node.objects(kube_cluster.kube_client)) >= 1 |
There was a problem hiding this comment.
Do we need this test?
According to the comments it's just supposed to be an example.
There was a problem hiding this comment.
Not absolutely necessary but still nice to make sure that the apiserver is reachable before proceeding with any further tests right ?
There was a problem hiding this comment.
Ok, why not, but then that's what the comment should say.
There was a problem hiding this comment.
Updated the comment.
|
That looks really great! 😲 👍 |
|
Maybe I should move the chart templating test before the jobs pushing the app to the catalogs ? 🤔 |
| # Do not trigger the job on merge to master. | ||
| branches: | ||
| ignore: | ||
| - master |
There was a problem hiding this comment.
You mean main right?
There was a problem hiding this comment.
I would have preferred but unfortunately, this repo's "main" branch is called "master" :/
There was a problem hiding this comment.
Is it? Maybe we should change it then :D
There was a problem hiding this comment.
I would totally agree :)
Towards giantswarm/roadmap#3612
This PR updates the tests run by ats so that those tests are run before pushing the app to all collections. The tests only check the following :