Adapt gitops add ... commands to CAPI release structure (Breaking)
#1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this on golem and the change works well. |
marians
added
the
breaking-change
ljakimczuk
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
gitops add workload-cluster>commands are adapted to work with the new release concept. Previously, they required setting the cluster-app version and the defaults-apps version, and allowed for passing additional default apps configuration. Now setting the release version is required instead.What is the effect of this change to users?
--cluster-releasegot removed--default-apps-releasegot removed--default-apps-user-configgot removed--releasehas been added to specify the release version to useAny background context you can provide?
giantswarm/roadmap#3630
Do the docs need to be updated?
Yes, PR is here: giantswarm/docs#2278
Should this change be mentioned in the release notes?
Is this a breaking change?
Yes