Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write all to giantswarm tenant #215

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

QuentinBisson
Copy link
Contributor

@QuentinBisson QuentinBisson commented Sep 5, 2024

Towards giantswarm/roadmap#3726

This PR is the start of the move to multi-tenancy for logs. For the new datasources to work, we need to send all logs to the giant swarm tenant.

This might impact Loki on some installations which we might need to scale up (either the number of buckets or the pod resources)

Once this PR is merged, we can try to work on supporting self-service tenancy on pod logs?

@QuentinBisson
Copy link
Contributor Author

Trying this out on grizzly

Copy link
Member

@TheoBrigitte TheoBrigitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the impact of this ? And why do we need it ?

@QuentinBisson
Copy link
Contributor Author

Oh I did not write anything ...

So once we have the multi-tenancy POC running, we will most likely have giantswarm logs under 1 tenant only so the impact is that loki will most likely not like it (need to be scaled) on some installations with lots of traffic but this would allow us to create alerts based on logs on MCs and WCs alike when now it only works on MCs

@QuentinBisson
Copy link
Contributor Author

@giantswarm/team-atlas I edited the top description. I forced pushed because the original main branch was too far behind

Copy link
Contributor

@QuantumEnigmaa QuantumEnigmaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants