-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write all to giantswarm tenant #215
base: main
Are you sure you want to change the base?
Conversation
fe77bf7
to
9d7a8c3
Compare
Trying this out on grizzly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the impact of this ? And why do we need it ?
Oh I did not write anything ... So once we have the multi-tenancy POC running, we will most likely have giantswarm logs under 1 tenant only so the impact is that loki will most likely not like it (need to be scaled) on some installations with lots of traffic but this would allow us to create alerts based on logs on MCs and WCs alike when now it only works on MCs |
9d7a8c3
to
7eaa4c3
Compare
@giantswarm/team-atlas I edited the top description. I forced pushed because the original main branch was too far behind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7eaa4c3
to
ade3e56
Compare
Towards giantswarm/roadmap#3726
This PR is the start of the move to multi-tenancy for logs. For the new datasources to work, we need to send all logs to the giant swarm tenant.
This might impact Loki on some installations which we might need to scale up (either the number of buckets or the pod resources)
Once this PR is merged, we can try to work on supporting self-service tenancy on pod logs?