add toggle for events-logger in observability-bundle configmap #270
Conversation
| @@ -59,11 +59,32 @@ func GenerateObservabilityBundleConfigMap(ctx context.Context, lc loggedcluster. | |||
| return v1.ConfigMap{}, errors.Errorf("unsupported logging agent %q", lc.GetLoggingAgent()) | |||
| } | |||
|
|
|||
| if observabilityBundleVersion.GE(semver.MustParse("0.10.0")) { | |||
There was a problem hiding this comment.
We still have a few 0.10.1 observability bundles. Do we not need this?
There was a problem hiding this comment.
Oh well no we do not
There was a problem hiding this comment.
I guess that this covers these cases right ?
There was a problem hiding this comment.
Well no because the Idea was to not deploy the grafana agent before v0.10.0 but we dont run those anymore anyway
There was a problem hiding this comment.
Ok added it back in a different way. All good for you ?
There was a problem hiding this comment.
Well no, because we should not set the value AT all before V10 and now you're Always setting it. Might as well remove the condition as it's unused anyway now
There was a problem hiding this comment.
Ok fine with me :)
Towards giantswarm/roadmap#3750
This PR adds the toggle for the events-logger in the observability-bundle configmap.
Checklist