add org CRD in helm chart #116
Conversation
helm/observability-operator/files/crds/organization.giantswarm.io_org.yaml
Outdated
Show resolved
Hide resolved
|
You're missing thé CRD into the helm chart right? |
QuantumEnigmaa
force-pushed
the
add-org-crd
branch
from
49ace4b
to
b4dbf91
Compare
Co-authored-by: Quentin Bisson <[email protected]>
| kind: GrafanaOrganization | ||
| metadata: | ||
| labels: | ||
| app.kubernetes.io/name: grafanaorganization |
There was a problem hiding this comment.
Also what is instance supposed to contain ?
Isn't this name label redundant with the CR name ?
| app.kubernetes.io/name: grafanaorganization | |
| app.kubernetes.io/name: MyOrganizationName |
There was a problem hiding this comment.
Isn't this name label redundant with the CR name ?
You're right.
Also what is instance supposed to contain ?
I think it's supposed to be the operator, so here : olly-op
There was a problem hiding this comment.
It does not makes sense to have instance, name, and managed-by labels if they all have the same value in the end.
There was a problem hiding this comment.
I agree but that's what we have for all of our operators if I'm not mistaken 🤔
There was a problem hiding this comment.
Components that are part of the application should have this label to be able to tell where they come from. What would be this label used for in the context of a GrafanaOrganization CR ?
There was a problem hiding this comment.
Hey what do we need to do here ?
There was a problem hiding this comment.
Can we remove the following labels ?
app.kubernetes.io/name: grafanaorganization
app.kubernetes.io/instance: grafanaorganization-sample
app.kubernetes.io/part-of: observability-operator
There was a problem hiding this comment.
Those are generated by kube-builder, I really don't care
There was a problem hiding this comment.
That's an example I assumed it was created by us and not generated
There was a problem hiding this comment.
No, anything under the samples directory is created by kube-builder
Co-authored-by: Théo Brigitte <[email protected]>
…rator into add-org-crd
| kind: GrafanaOrganization | ||
| metadata: | ||
| labels: | ||
| app.kubernetes.io/name: grafanaorganization |
There was a problem hiding this comment.
Can we remove the following labels ?
app.kubernetes.io/name: grafanaorganization
app.kubernetes.io/instance: grafanaorganization-sample
app.kubernetes.io/part-of: observability-operator
Remove labels to make @TheoBrigitte happy
Towards giantswarm/roadmap#3695
This PR only adds the CRD for the organization as defined here. Follow-up PRs will be created to add the related services/controllers in the operator.
Checklist